-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RLE dump code #7691
Add RLE dump code #7691
Conversation
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Codecov Report
@@ Coverage Diff @@
## master #7691 +/- ##
==========================================
- Coverage 39.56% 39.41% -0.16%
==========================================
Files 637 637
Lines 67924 67979 +55
==========================================
- Hits 26877 26796 -81
- Misses 36445 36556 +111
- Partials 4602 4627 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what motivated this
I was analyzing how good/bad our RLE+ encoding is in practice. We could save 18% of RLE+ storage but it is such a small fraction that it isn't worth the complexity right now (after collecting data I know that RLEs are only ~10MB of chain state, but the churn is frequent). If I were to design RLE+ today I would have gone with RLE with Huffman coding of small runs and additional data lengths. |
No description provided.