ffiwrapper: Validate PC2 by calling C1 with random seeds #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Nov 30, 2021
| return nil, xerrors.Errorf("unmarshaling pc1 output: %w", err) | ||
| } | ||
|
|
||
| p1odec["_lotus_SealRandomness"] = ticket |
There was a problem hiding this comment.
This should probably be a constant in this file or some such...also maybe rename it to indicate it's not real randomness, just for sanity-checking?
There was a problem hiding this comment.
Well, it is the real seal randomness (aka the ticket), we use this json thing to transport it into PC2 which doesn't have an easy way to get to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets lotus detect compute errors in PC1/PC2 early, before precomitting to sectors which can't be proven (and can't be recovered because the CommR on chain is bad)
Closes #7702