Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cli deal command get Block Delay specific to build #8896

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jun 22, 2022

Related Issues

Closes #7674

Proposed Changes

The deal making cli was using mainnet parameters for block time, disallowing any deals shorter than 180 days, but for a devnet with a block time of 4s this is over the maximum lifetime of a deal. This led to the cli not being able to make deals for devnets.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball marked this pull request as ready for review June 22, 2022 18:43
@geoff-vball geoff-vball requested a review from a team as a code owner June 22, 2022 18:43
@rjan90
Copy link
Contributor

rjan90 commented Jun 22, 2022

This seems to fix: #7674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants