M2.1: Update FVM for Selenium (r02) #9260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable for wallaby.
Stebalien
force-pushed
the
feat/update-fvm
branch
from
ac5a9cc to
0101adb
Compare
vyzo
approved these changes
Sep 3, 2022
| @@ -22,6 +22,7 @@ const GenesisFile = "" | |||
| // VERY experimental! Should not be merged into master / any release branch yet! | |||
| var NetworkBundle = "devnet-wasm" | |||
| var BundleOverrides map[actors.Version]string | |||
| var ActorDebugging = false | |||
There was a problem hiding this comment.
we probably want this to be true so that peoplr can get logs and backtraces.
| @@ -17,6 +17,7 @@ import ( | |||
|
|
|||
| var NetworkBundle = "wallaby" | |||
| var BundleOverrides map[actors.Version]string | |||
| var ActorDebugging = true | |||
There was a problem hiding this comment.
Should probably call out that this is changing from true to false.
There was a problem hiding this comment.
Worth indicating in the handoff to Wallaby that we're enabling this feature now so that node operators expect the extra output in logs?
raulk
approved these changes
Sep 3, 2022
raulk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the FVM in experimental/m2:
This also switches the FFI branch to feat/m2 from experimental/m2. cc @vyzo could you take a look at the diff?