Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post worker sched: Don't check worker session in a busy loop #9495

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 14, 2022

Related Issues

Should help with #8362

Proposed Changes

On master the PoSt worker scheduler would check worker session at some interval, but the way the logic is implemented, it only sleeps if the check has failed. This results it a flood of requests between lotus-miner<->lotus-worker, which may lead to exhausting resources needed to make those http requests, leading to all sorts of random RPC-related issues.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner October 14, 2022 14:01
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@arajasek arajasek merged commit 8a2f8c3 into master Oct 14, 2022
@arajasek arajasek deleted the fix/postsched-ping-flood branch October 14, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants