feat: Check for allocation expiry when waiting to seal sectors #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/check-allocation-expiry
branch
3 times, most recently
from
035c6a6 to
2b60448
Compare
|
Currently failing sector_prefer_no_upgrade |
magik6k
reviewed
Jan 4, 2023
|
Will need rebase after #9941 is merged |
geoff-vball
force-pushed
the
gstuart/check-allocation-expiry
branch
4 times, most recently
from
17153ea to
510dfef
Compare
geoff-vball
force-pushed
the
gstuart/check-allocation-expiry
branch
from
510dfef to
12a06de
Compare
|
@magik6k I've fixed the test that was failing here and it's ready for another look. |
magik6k
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #9368
Proposed Changes
Checks for allocation expirations to make sure we don't wait too long before sealing. This is slightly tricky because allocations are allowed to expire, the miner will just not get the increased power for the verified deal.
Additional Info
This could use some testing.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps