Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: propagate syscall error from send #1452

Closed
Stebalien opened this issue Jan 13, 2023 · 3 comments
Closed

EVM: propagate syscall error from send #1452

Stebalien opened this issue Jan 13, 2023 · 3 comments
Assignees

Comments

@Stebalien
Copy link
Member

send_generalized now returnes the syscall error directly. We need to bubble this through the EVM and:

  1. Use it in the call_actor precompile.
  2. Consider using it in other cases as well (e.g., actor construction).
@maciejwitowski
Copy link
Contributor

@Stebalien is half-step from your PR enough for C.2 or do we need this issue resolved?

@arajasek
Copy link
Contributor

Defer to @Stebalien but I think this can be a C.3 thing.

@maciejwitowski maciejwitowski added this to the M2.1 (r12) Carbonado.3 milestone Jan 13, 2023
@maciejwitowski
Copy link
Contributor

@mriise is this something you can handle this week? Or would @vyzo be a better person? We really need to triage a few more issues and get done this week.
cc @Stebalien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants