fix: check actor error codes #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: 1. Extracts the actor code checking to methods on the ActorError itself. 2. Uses them in the EVM.
|
The full fix is filecoin-project/ref-fvm#1452, but this is a half-step there. |
Stebalien
force-pushed
the
next-eam-refactor
branch
2 times, most recently
from
1af720b
to
90febe0
Compare
arajasek
approved these changes
Jan 13, 2023
| if !result.exit_code.is_success() { | ||
| return Err(ActorError::checked_with_data( | ||
| result.exit_code, | ||
| format!("failed to call {to} on method {method}"), |
There was a problem hiding this comment.
missing the {to} param here?
There was a problem hiding this comment.
Nope. Rust format strings let you inline variables like that.
There was a problem hiding this comment.
(and they're type-checked at compile time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit: