Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC receipts are missing 'v' field #1662

Closed
jimpick opened this issue Feb 13, 2023 · 9 comments
Closed

JSON-RPC receipts are missing 'v' field #1662

jimpick opened this issue Feb 13, 2023 · 9 comments

Comments

@jimpick
Copy link
Contributor

jimpick commented Feb 13, 2023

Using a recent v1.20.0 commit:

$ cast tx --rpc-url=https://glif-fvm-v1-20-0-20230213-f427c2b.quick.cluster-3.localnet.farm/rpc/v1 0x8234d78f71b8481fac79f5574cc831ceb8e317f4098546944431410b4d2a8328
Error: 
Deserialization Error: missing field `v` at line 1 column 715. Response: {"chainId":"0x1df5e76","nonce":"0x5","hash":"0x8234d78f71b8481fac79f5574cc831ceb8e317f4098546944431410b4d2a8328","blockHash":"0xbf204c1404e6ffd31a407cf0d78311b7d0347524631171f81c312b127a141593","blockNumber":"0x3f","transactionIndex":"0x5","from":"0x3972e844729522d367bfa1d64368346d7cceea59","to":"0xd6fb0f4cb3ba0387ba9e56113d60ad76f8278b3b","value":"0x0","type":"0x2","input":"0x7a9e5e4b000000000000000000000000d6fb0f4cb3ba0387ba9e56113d60ad76f8278b3b","gas":"0x10000000","maxFeePerGas":"0xb2d1413e","maxPriorityFeePerGas":"0xb2d05e00","accessList":[],"yParity":"0x1","r":"0x63c67b08915b68bc1d5c4dce6862e64d0fef2ff7562dad7dd2ec39776af80ee1","s":"0x214fb4fc8427ae3fbff8f194391efe2ad423f2742d56a0a6c566a603e967086a"}

$ lotus version
Daemon:  1.19.1-dev+2k+git.f427c2b.dirty+api1.5.0
Local: lotus version 1.19.1-dev+2k+git.f427c2b.dirty

This is also breaking forge script: #1641
@Stebalien
Copy link
Member

Any idea what endpoint that's hitting?

@Stebalien
Copy link
Member

(nvm)

@Stebalien
Copy link
Member

I'm very confused:

https://github.com/filecoin-project/lotus/blob/f427c2b566311798063362c437e9187af82ef857/chain/types/ethtypes/eth_transactions.go#L42

@Stebalien
Copy link
Member

That looks like an upstream bug? The field should be yParity, not v.

@Stebalien
Copy link
Member

What version of cast?

@jimpick
Copy link
Contributor Author

jimpick commented Feb 13, 2023 

$ cast --version
cast 0.2.0 (250cc85 2022-12-02T00:18:26.200251Z)

@Stebalien
Copy link
Member

Ok, I'm no longer confused. Just annoyed:

filecoin-project/lotus#10102 (comment)

Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 13, 2023
@Stebalien
fix: eth: rename yParity to v in transaction return values
0a79959 
The openethereum docs say it should be `yParity`, but Geth uses `v` and
tools rely on `v` so we should use `v`. I've taken the liberty of fixing
the conformance tests at the same time.

fixes filecoin-project/ref-fvm#1662
@Stebalien Stebalien mentioned this issue Feb 13, 2023
Merged
4 tasks
@Stebalien
Copy link
Member

@jimpick can you test filecoin-project/lotus#10264?

raulk pushed a commit to filecoin-project/lotus that referenced this issue Feb 13, 2023
@Stebalien
fix: eth: rename yParity to v in transaction return values (#10264)
a16c540 
fixes filecoin-project/ref-fvm#1662
@Stebalien
Copy link
Member

Should be fixed in the latest release/v1.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimpick @Stebalien