Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard exit code for non-payable functions #1696

Merged

Conversation

alexytsu
Copy link
Contributor

@alexytsu alexytsu commented Mar 7, 2023

Adds a standard exit code that allows actors to indicate they are not prepared to receive funds: filecoin-project/builtin-actors#836

Example usage in builtin-actors: filecoin-project/builtin-actors#1241

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #1696 (3499a68) into master (7c44970) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1696   +/-   ##
=======================================
  Coverage   55.42%   55.43%           
=======================================
  Files         146      146           
  Lines       14031    14031           
=======================================
+ Hits         7777     7778    +1     
+ Misses       6254     6253    -1     
Impacted Files Coverage Δ
shared/src/error/mod.rs 0.00% <ø> (ø)
ipld/kamt/src/bitfield.rs 87.89% <0.00%> (+0.63%) ⬆️

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Let's wait for @Stebalien as he suggested it.

@Stebalien
Copy link
Member

It works for me too. My only reservations are:

  1. We didn't reserve enough of these...
  2. FEVM actors won't use this exit code unless we liberally apply some magic sauce.

But I think we should have this.

@Stebalien Stebalien merged commit c7b80f0 into filecoin-project:master Mar 7, 2023
@alexytsu alexytsu deleted the alex/non-payable-exit-codes branch May 10, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants