Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: example steps for publishing FVM-crates #2032

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 19, 2024

Add example steps for publishing FVM-crates

Add example steps. for publishing FVM-crates
@rjan90 rjan90 requested a review from BigLep August 19, 2024 11:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.63%. Comparing base (2f5340c) to head (ebe84a3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2032   +/-   ##
=======================================
  Coverage   75.63%   75.63%           
=======================================
  Files         155      155           
  Lines       15676    15676           
=======================================
  Hits        11857    11857           
  Misses       3819     3819           

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90 : I pushed a commit on top which rearranges things and adds some more content. This comes from me reading through the whole document and wanting to make sure I understood everything. My main changes were:

  1. Factoring out "Primary Crates" to a term we could link to.
  2. Adding more headers
  3. Adding scripting that can be copy/pasted
  4. Some minor fixes

@BigLep
Copy link
Member

BigLep commented Aug 19, 2024

Thinking on this more, I think the text we have added is all better than what it was before. That said, ideally I think we'd have a release issue template that covers all these steps since the release isn't managed purely by a PR but has various steps afterwards. We can do that another time though.

I think the content of this doc also suffices #2018 enabling us to close it after merge.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Loeppky <biglep@filoz.org>
@rjan90
Copy link
Contributor Author

rjan90 commented Aug 20, 2024

Thinking on this more, I think the text we have added is all better than what it was before. That said, ideally I think we'd have a release issue template that covers all these steps since the release isn't managed purely by a PR but has various steps afterwards. We can do that another time though.

I opened a ticket for this here: #2033, just so that we have it in our backlog.

@rjan90 rjan90 linked an issue Aug 20, 2024 that may be closed by this pull request
@rjan90 rjan90 merged commit 1e31330 into master Aug 20, 2024
14 checks passed
@rjan90 rjan90 deleted the phi/release-crates-process branch August 20, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create updated release process
3 participants