Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release.toml config #1677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Mar 9, 2023

This way releases can be made with the most recent version 0.25.5 of cargo-release. New major releases can be cut with simply running:

cargo release major --execute

Prior to this change fil-proofs-tooling wasn't tagged. With this change it's tagged just like any other crates. That adds more consistency. It still isn't published to crates.io as intended.

The consolidate-commits = false option makes sure that each crate gets its own tag with a commit message that contains its version number. Without this setting, it would only say "Release" without further information.

@vmx
Copy link
Contributor Author

vmx commented Mar 9, 2023

I should note that this PR preserves the current behaviour. Those newer versions of cargo-release make it possible to have a single tag/commit for everything. As we release all version at once we might even want that. I leave the decision to @cryptonemo.

@cryptonemo cryptonemo closed this Nov 7, 2024
@vmx
Copy link
Contributor Author

vmx commented Nov 7, 2024

I think this one is still worth having, in case someone wants to cut a release with a newer cargo-release version.

@cryptonemo
Copy link
Collaborator

I think this one is still worth having, in case someone wants to cut a release with a newer cargo-release version.

I cut releases with newer versions just fine

@vmx
Copy link
Contributor Author

vmx commented Nov 8, 2024

I cut releases with newer versions just fine

I get:

$ cargo release --version
cargo-release 0.25.10
$ cargo release
error: Failed to parse `/home/vmx/src/pl/filecoin/rust-fil-proofs/release.toml`: TOML parse error at line 2, column 1
  |
2 | pro-release-commit-message = "chore({{crate_name}}): starting development cycle for {{next_version}}"
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unknown field `pro-release-commit-message`, expected one of `allow-branch`, `sign-commit`, `sign-tag`, `push-remote`, `registry`, `release`, `publish`, `verify`, `owners`, `push`, `push-options`, `shared-version`, `consolidate-commits`, `pre-release-commit-message`, `pre-release-replacements`, `pre-release-hook`, `tag-message`, `tag-prefix`, `tag-name`, `tag`, `enable-features`, `enable-all-features`, `dependent-version`, `metadata`, `target`, `rate-limit`, `certs-source`

@cryptonemo cryptonemo reopened this Nov 8, 2024
@cryptonemo
Copy link
Collaborator

Ok, thanks. If you can rebase it, I'll give it a go

@cryptonemo
Copy link
Collaborator

Ok, thanks. If you can rebase it, I'll give it a go

I don't usually use the github buttons because rebases are pretty easy, but maybe the 'Update with rebase' will do the trick?

This way releases can be made with the most recent version 0.25.5 of
cargo-release. New major releases can be cut with simply running:

    cargo release major --execute

Prior to this change `fil-proofs-tooling` wasn't tagged. With this
change it's tagged just like any other crates. That adds more consistency.
It still isn't published to crates.io as intended.

The `consolidate-commits = false` option makes sure that each crate
gets its own tag with a commit message that contains its version number.
Without this setting, it would only say "Release" without further
information.
@vmx
Copy link
Contributor Author

vmx commented Nov 8, 2024

I don't usually use the github buttons because rebases are pretty easy, but maybe the 'Update with rebase' will do the trick?

I just rebased it locally, that was easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants