Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* feat(storage-proofs): switch post challenges to 40 #985

Merged
merged 4 commits into from
Dec 10, 2019

Conversation

dignifiedquire
Copy link
Contributor

No description provided.

Copy link
Contributor

@laser laser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I wouldn't have added the only-election-post flag. But I see no reason to block you.

partitions: DEFAULT_POREP_PROOF_PARTITIONS,
},
);
if !only_election_post {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dignifiedquire - Seems a little weird to allow the consumer to specify that they want:

  1. Only PoRep parameters
  2. Both PoRep and PoSt parameters

and not also...

  1. Only PoRep parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, it wwas what I needed today

@dignifiedquire dignifiedquire changed the title Feat/epost param * feat(storage-proofs): switch post challenges to 40 Dec 10, 2019
@dignifiedquire dignifiedquire merged commit d815366 into master Dec 10, 2019
@dignifiedquire dignifiedquire deleted the feat/epost-param branch December 10, 2019 20:14
dignifiedquire added a commit to filecoin-project/filecoin-ffi that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants