Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentinel module scaffolding to Lotus #179

Closed
iand opened this issue Feb 22, 2021 · 2 comments
Closed

Add Sentinel module scaffolding to Lotus #179

iand opened this issue Feb 22, 2021 · 2 comments
Assignees
Labels
kind/feature New feature request P1 P1: Must be resolved

Comments

@iand
Copy link
Contributor

iand commented Feb 22, 2021

Create the scaffolding for a Sentinel module and API in Lotus. The scope of this issue is just enough to start Lotus in sentinel mode and start a watch that simply logs tipsets as they are received. This will provide a foundation to introduce data extraction and indexing in subsequent PRs.

Add a CLI flag to allow Lotus to be started as a daemon in "sentinel" mode:

lotus daemon --sentinel

Allow a watch to be started via CLI with a default confidence level:

lotus sentinel watch

Initial spike for reference: https://github.com/iand/lotus/blob/65a290b62edb8e26dc86d441b58e24f0d43b3637/node/impl/sentinel/sentinel.go

@iand iand added kind/feature New feature request P1 P1: Must be resolved labels Feb 22, 2021
@frrist frrist self-assigned this Feb 23, 2021
@frrist
Copy link
Member

frrist commented Feb 24, 2021

In draft here: filecoin-project/lotus#5672

@frrist
Copy link
Member

frrist commented Feb 24, 2021

Message from Magik relating to this work:

I'd prefer this mode to be hidden behind build-time tag, or implemented as a plugin (we can give plugins hooks to fx/cli) - I really don't love the idea of adding flags to the daemon command, it gets messy over time (see go-ipfs)

I think a build flag will be the easiest solution here. A plugin implementation would require more work and could be explored at a later time or as a follow on.

frrist added a commit to filecoin-project/lotus that referenced this issue Feb 26, 2021
- includes cli command to start a watch that logs
tipsets as they are received. closes filecoin-project/sentinel#179
@frrist frrist closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants