Skip to content

Commit

Permalink
Update audit section with reports for SnarkPack (#1261)
Browse files Browse the repository at this point in the history
* Update audit section with reports for SnarkPack

* Remove broken link to inaccessible security report

* Prettier format

* Fix husky pre-commit hook

---------

Co-authored-by: Ian Davis <jungziege@gmail.com>
  • Loading branch information
nikkolasg and ianconsolata authored Oct 31, 2024
1 parent d2d835f commit 11169e5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions content/appendix/audit_reports.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ This audit covers the implementation of Filecoin's builtin Actors, focusing on t

## Proofs

### `2021-05-31` SnarkPack audit

An audit was conducted on the cryptographic part of [SnarkPack](https://eprint.iacr.org/2021/529.pdf), that is used in the [FIP0009](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0009.md):

- [Report](https://hackmd.io/@LIRa8YONSwKxiRz3cficng/B105no8w_) from Matteo Campanelli, a well known cryptography [researcher](https://www.binarywhales.com/)

One major issue was found in the report by Campanelli where the challenges of each prove commits were not tied to the aggregated proof; this could have led up to malicious miner forge valid aggregated proofs without the individual prove commits. The rest of the issues were of medium to informal severity.

### `2020-10-20` Filecoin Bellman and BLS Signatures

- Report: [**Filecoin Bellman/BLS Signatures Cryptography Review**](https://research.nccgroup.com/wp-content/uploads/2020/10/NCC_Group_ProtocolLabs_PRLB007_Report_2020-10-20_v1.0.pdf)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"globby": "^11.0.1",
"graphviz-cli": "^2.0.0",
"hugo-extended": "^0.113.0",
"husky": ">=4",
"husky": "^4.3.8",
"jsdom": "^22.1.0",
"lint-staged": ">=10",
"np": "^6.5.0",
Expand Down

0 comments on commit 11169e5

Please sign in to comment.