Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): intro section tidy up #1225

Merged
merged 6 commits into from
Oct 19, 2020
Merged

fix(content): intro section tidy up #1225

merged 6 commits into from
Oct 19, 2020

Conversation

yiannisbot
Copy link
Collaborator

This PR deletes outdated TODOs and diagrams and includes an updated state diagram. This small updates comes while we work on a more substantial revision to the Intro section, which comes with #1168

@yiannisbot yiannisbot added hint: active Hint: Tasks currently in an active project hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec labels Oct 19, 2020
Actor State Diagram
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the file embed instead of inlining.

mermaid shortcode will probably go away.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done!

@@ -4,7 +4,7 @@
<script>
mermaid.initialize({
startOnLoad:false,
theme: 'dark',
theme: 'forest',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this plz

Copy link
Collaborator Author

@yiannisbot yiannisbot Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugomrdias do you mean set it back to "dark". It looks pretty horrible in my browser with most blocks having black letters on black background. Is there a problem with the "forest" theme?

@hugomrdias hugomrdias merged commit ba64d09 into master Oct 19, 2020
@hugomrdias hugomrdias deleted the intro-tidy-up branch October 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: active Hint: Tasks currently in an active project hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants