Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add sign record config #150

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close filecoin-project/venus#5994

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #150 (8742514) into master (c2a3707) will decrease coverage by 0.15%.
The diff coverage is 21.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   34.61%   34.46%   -0.15%     
==========================================
  Files          41       41              
  Lines        2574     2591      +17     
==========================================
+ Hits          891      893       +2     
- Misses       1529     1542      +13     
- Partials      154      156       +2     
Flag Coverage Δ
unittests 34.46% <21.05%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
storage/sqlite/sign_record.go 48.54% <16.66%> (-7.78%) ⬇️
build/builder.go 89.55% <100.00%> (+0.15%) ⬆️

@simlecode simlecode merged commit 9a596bd into master Aug 7, 2023
@simlecode simlecode deleted the feat/add-sign-record-config branch August 7, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants