Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus and jeager imports in metrics/export.go #2717

Merged
merged 2 commits into from
May 10, 2019

Conversation

nijynot
Copy link
Contributor

@nijynot nijynot commented May 4, 2019

Building localnet gives e.g. the error

package go.opencensus.io/exporter/prometheus: cannot find package "go.opencensus.io/exporter/prometheus" in any of:
	/home/user/go/src/go.opencensus.io/exporter/prometheus (from $GOROOT)
	/home/user/code/go/src/go.opencensus.io/exporter/prometheus (from $GOPATH)

and is because the packages have been moved moved to contrib.*.

Related comment: census-instrumentation/opencensus-go#1118 (comment)

@travisperson
Copy link
Contributor

I think we need to do this update regardless, but I wasn't able to reproduce this.

My repro attempt was:

go-filecoin $ go clean -modcache
go-filecoin $ go run ./build deps; go run ./build build
localnet $ env GO111MODULE=on go build -o localnet main.go

If you are trying to build, you may try the above to see if it unblock you till we merge this change.

@travisperson travisperson requested review from frrist and anorth May 4, 2019 21:22
Copy link
Contributor

@travisperson travisperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accept these changes we just need to update the go.mod + go.sum files. You can do this pretty easily by enabling gomod and running go get

env GO111MODULE=on go get contrib.go.opencensus.io/exporter/prometheus
env GO111MODULE=on go get contrib.go.opencensus.io/exporter/jaeger

Normally you can do this with env GO111MODULE=on go mod tidy, but our go.mod hygiene is a little lacking and it will introduce quite a few changes not related to this PR. So for this PR we can just explicitly update these two.

anorth added a commit that referenced this pull request May 5, 2019
This is the result of `go mod tidy`. Need for this noted at #2717 (review)
anorth added a commit that referenced this pull request May 8, 2019
This is the result of `go mod tidy`. Need for this noted at #2717 (review)
anorth added a commit that referenced this pull request May 8, 2019
This is the result of `go mod tidy`. Need for this noted at #2717 (review)
@nijynot
Copy link
Contributor Author

nijynot commented May 10, 2019

Updated the go.mod and go.sum files accordingly so that they include contrib.* prometheus and jaeger.

@frrist frrist merged commit 0df29c1 into filecoin-project:master May 10, 2019
@frrist
Copy link
Member

frrist commented May 10, 2019

Thank you for the contribution @nijynot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants