Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FILE-4 - move the node list from a char box in the upper right to a dedicated column on the left side of the page #53

Closed
wants to merge 4 commits into from
Closed

FILE-4 - move the node list from a char box in the upper right to a dedicated column on the left side of the page #53

wants to merge 4 commits into from

Conversation

gitstart
Copy link
Contributor

What does this PR do?

  • Move the node list from a char box in the upper right to a dedicated column on the left side of the page
  • 2nd column, node id, remains, but the copy button is hidden by default and only becomes displayed, position: absolute on mouseover. thus it takes up no permanent, static space
  • 4th column, payout status, can be shrunk by replacing valid and pending with two different icons that, on mouseover, show the full Valid or Pending. for example, a green checkbox logo that, on mouseover, displays Valid and a yellow clock logo that, on mouseover, displays Pending
  • 6th column, retrievals, shorten from the full 72,102, 4,003,018 to use metric suffix: 72k, 4M, etc

Issue reference

Demo video/scrennshot:

This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

@gitstart gitstart marked this pull request as ready for review August 14, 2023 06:23
@gitstart
Copy link
Contributor Author

Updated loom video after #52 got merged https://www.loom.com/share/0e1045977a364cf6abef80843dc4f771?sid=8d2d3906-2693-4322-b1cf-03b9d53d3a4d

@gitstart
Copy link
Contributor Author

Good day @guanzo this PR is ready for review

@gitstart
Copy link
Contributor Author

Good day @guanzo this PR is ready for review

@guanzo just a gentle reminder that this PR is still up for review

@gitstart
Copy link
Contributor Author

@DiegoRBaquero this PR is ready for review

@gitstart
Copy link
Contributor Author

@guanzo @joaosa @DiegoRBaquero this PR is ready for review

DiegoRBaquero
DiegoRBaquero approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@DiegoRBaquero DiegoRBaquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but want a second approver

@guanzo
Copy link
Collaborator

guanzo commented Sep 19, 2023

Apologies for the late review.

Can you add an icon for the "Postponed" status? It'd be best if all statuses had an icon. Perhaps the same icon as the "In Progress" but with a gray color? Up to you.

@gitstart
Copy link
Contributor Author

@guanzo updated
img1

joaosa
joaosa approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GitStartHQ GitStartHQ closed this by deleting the head repository Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoRBaquero DiegoRBaquero DiegoRBaquero approved these changes

@joaosa joaosa joaosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gitstart @guanzo @joaosa @DiegoRBaquero @GitStartHQ