Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor modules library #109

Merged
merged 3 commits into from
Apr 26, 2023
Merged

refactor modules library #109

merged 3 commits into from
Apr 26, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber requested a review from bajtos April 26, 2023 09:55
bajtos
bajtos approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

The changes look mostly good, please consider my two comments below.

scripts/post-install.js Show resolved Hide resolved
lib/saturn-node.js Outdated Show resolved Hide resolved
@juliangruber juliangruber merged commit 94801cf into main Apr 26, 2023
@juliangruber juliangruber deleted the refactor/modules branch April 26, 2023 10:26
@bajtos bajtos mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos