docs: Zinnia in Filecoin Station [ADR] #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
11 tasks
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
docs/architecture-decision-records/2023-03-integration-with-station.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
I decided to postpone the implementation of reading the wallet address from a config file. I think the hardcoded testnet address is good enough for the initial module builders. We can wait to build more complex functionality until there is specific demand from Zinnia users. See 5b79d36 |
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Mar 22, 2023
|
@juliangruber I think I have addressed all your comments. Does my proposal LGTY now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A design proposal for integrating Zinnia into Filecoin Station.
See #75