Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build zinniad release binaries #158

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat: build zinniad release binaries #158

merged 1 commit into from
Mar 29, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 29, 2023

Modify our Release workflow to create packages for zinniad binary too.

See #75

@bajtos
Copy link
Member Author

bajtos commented Mar 29, 2023

I have manual tested the archives produced by this workflow run.

Windows

~/Downloads/archives-windows-x64 ❯ unzip -t zinnia-windows-x64.zip
Archive:  zinnia-windows-x64.zip
    testing: zinnia.exe               OK
No errors detected in compressed data of zinnia-windows-x64.zip.
~/Downloads/archives-windows-x64 ❯ unzip -t zinniad-windows-x64.zip
Archive:  zinniad-windows-x64.zip
    testing: zinniad.exe              OK
No errors detected in compressed data of zinniad-windows-x64.zip.

Linux

~/Downloads/archives-linux-x64 ❯ tar tzf zinnia-linux-x64.tar.gz
zinnia
~/Downloads/archives-linux-x64 ❯ tar tzf zinniad-linux-x64.tar.gz
zinniad

macOS

~/Downloads/archives-macos-x64 ❯ unzip -t zinnia-macos-x64.zip
Archive:  zinnia-macos-x64.zip
    testing: zinnia                   OK
No errors detected in compressed data of zinnia-macos-x64.zip.
~/Downloads/archives-macos-x64 ❯ unzip -t zinniad-macos-x64.zip
Archive:  zinniad-macos-x64.zip
    testing: zinniad                  OK
No errors detected in compressed data of zinniad-macos-x64.zip.

On macOS, I have to allow running zinnia and zinniad binaries in Security settings, because we are not notarising the binaries yet (see #23).

After that, all works well.

CLI:

❯ ./zinnia run ~/src/zinnia/mod-peer-checker/peer-checker.js
Checking /dnsaddr/bootstrap.libp2p.io/p2p/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN
Recevied Identify Message: 1497 bytes

Daemon:

❯ ./zinniad -w f1asd ~/src/zinnia/mod-peer-checker/peer-checker.js
[2023-03-29T10:32:51Z INFO  zinniad] Starting zinniad with config CliArgs { wallet_address: "f1asd", root_dir: "/Users/bajtos/Library/Application Support/app.filstation.zinniad", files: ["/Users/bajtos/src/zinnia/mod-peer-checker/peer-checker.js"] }
{"type":"activity:info","module":null,"message":"Module Runtime started."}
[2023-03-29T10:32:51Z INFO  zinniad] Starting module file:///Users/bajtos/src/zinnia/mod-peer-checker/peer-checker.js
[2023-03-29T10:32:51Z INFO  module:/Users/bajtos/src/zinnia/mod-peer-checker/peer-checker] Checking /dnsaddr/bootstrap.libp2p.io/p2p/QmQCU2EcMqAqQPR2i9bChDtGNJchTbq5TbXJJ16u19uLTa
[2023-03-29T10:32:52Z INFO  module:/Users/bajtos/src/zinnia/mod-peer-checker/peer-checker] Recevied Identify Message: 1777 bytes
[2023-03-29T10:32:52Z INFO  module:/Users/bajtos/src/zinnia/mod-peer-checker/peer-checker] Submitted stats to InfluxDB.
{"type":"jobs-completed","total":1,"modules":{"/Users/bajtos/src/zinnia/mod-peer-checker/peer-checker":1}}

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos marked this pull request as ready for review March 29, 2023 10:36
@bajtos bajtos mentioned this pull request Mar 29, 2023
11 tasks
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yabba dabba doo!

@bajtos bajtos merged commit c6ecd9e into main Mar 29, 2023
@bajtos bajtos deleted the package-zinniad branch March 29, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants