Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is padding added to the car file? #35

Open
pyropy opened this issue May 31, 2022 · 4 comments
Open

Is padding added to the car file? #35

pyropy opened this issue May 31, 2022 · 4 comments

Comments

@pyropy
Copy link
Contributor

pyropy commented May 31, 2022

When chunking file into car files, is the padding added to the car file?
@qianhh
Copy link
Contributor

qianhh commented Jun 7, 2022 •
edited
Loading

Isn’t. In the latest main branch, the rename parameter can be enabled to generate the CAR file with commP CID, and also need to enable the calc-commp parameter.

@beeleelee
Copy link
Contributor

Noop, padding doesn't added to the car file. Even in the latest main branch, then rename parameter can enable use piececid
instead of the car root cid for the name of the car file

@pyropy
Copy link
Contributor Author

pyropy commented Jun 8, 2022

Would that be a good feature to add? I'm looking to prepare CAR file for add piece.

@beeleelee
Copy link
Contributor

Sounds good!

beeleelee added a commit that referenced this issue Jun 10, 2022
@beeleelee
feat:enable pad car file to become a piece file #35
8ef4d61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beeleelee @qianhh @pyropy