Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable / disable selection of multiple items #74

Closed
wants to merge 2 commits into from

Conversation

tichapeco
Copy link

Function to enable / disable selection of multiple items in the is-row-checkable property.

Can you validate that it is correct?

@alcalbg
Copy link
Member

alcalbg commented Apr 24, 2020

Hi,

Thank you for your contribution!

Enable/disable selection is a great addition, it would be even better if we can remove checkboxes completely so that the user is less confused. Maybe something like this:

:is-row-checkable="(row) => row.type != 'back'"
:checkable="can('batchDownload') || can('write') || can('zip')"

However, design changes are not consistent and somehow duplicated:

Screenshot 2020-04-24 at 08 44 58

@pauloklaus
Copy link
Contributor

Yes! Removing the checkbox was our first attempt. Unfortunately the component does not work. The other change, to show the title, we submitted incorrectly.

alcalbg added a commit that referenced this pull request May 9, 2020
@alcalbg alcalbg closed this May 9, 2020
vagra pushed a commit to vagra/filegator that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants