-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix var to const #723
base: master
Are you sure you want to change the base?
fix var to const #723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, you can also add 'use strict'
at the top of the page.
Looks good. As stated, 'use strict' can be added for strict mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I also agree with both your reviewers that you need to add 'use strict;
to the top of the file. Please do that, then git add
, git commit
, and git push
again to this same branch. It will get added. Let me know when that's done and I'll re-review.
@QingLianLiu how is this coming? |
Fix var into const