Skip to content

Conversation

@heftymouse
Copy link
Contributor

It now authenticates properly with GitHub when pushing. Previously it was using Personal Access Token instead of x-access-token as the HTTP username. Also added some error handling

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Add unformatted files to a PR and attempt to format (Update HomePage.xaml heftymouse/Files#9 (comment))

Screenshots (optional)
Add screenshots here.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title GitHub: Fix formatting workflow GitHub: Fixed formatting workflow Apr 4, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 4, 2024
@yaira2 yaira2 merged commit 07bfd66 into files-community:main Apr 4, 2024
marianalcar pushed a commit to marianalcar/Files that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants