Code Quality - Added StorageBar and StorageRing Controls

[mdtauk]

Resolved / Related Issues
This adds StorageBar and StorageRing controls to the Files.App.Controls project for future use, as well as a test page in the UITests app for testing behaviour.

I am no expert when it comes to coding let alone making Controls, so I would appreciate these be given a thorough review to ensure there are no edge cases I have not anticipated, as well as general changes to improve the code by those with the expertise and experience. I will call out @yaira2 and @0x5bfa who have been seeing my progress via Discord as I was working on them. But also anyone with control and or mathematics experience who can ensure I am using the most optimal calculations for the angles and size calculations. @marcelwgn has contributed to the Community Toolkit so will be able to make some comments on my properties and general code quality.

I also want to indicate I took great inspiration from the RadialGuage control in the Toolkit, as well as the blogposts and sample code from Diederik Krols and his blog posts.

• https://xamlbrewer.wordpress.com/2018/12/06/creating-bindable-path-controls-in-uwp/
• https://xamlbrewer.wordpress.com/2016/12/16/a-percentage-ring-control-for-uwp/
• https://xamlbrewer.wordpress.com/2017/03/22/a-radial-range-indicator-control-for-uwp/

As well as Co-Pilot for maths queries and interpolation code suggestions, here are other posts I found helpful

• https://www.reddit.com/r/askmath/comments/17iqnae/circle_packing/
• https://www.vbforums.com/showthread.php?283960-Packing-circles-Resolved
• https://www.researchgate.net/figure/Circle-Packing-solution-from-N-8-to-N-13-and-equivalent-Point-Packing-problem-for-N_fig1_354328815
• https://thecolorofcode.com/xaml/wpfxaml-eine-runde-fortschrittsanzeige/

[mdtauk]

A final round of cleaning up or adding comments to parts of the controls can be done soon, but I wanted to get the functional code in after working on it on and off outside of the repo and adding it to the repo over the past week or so

[mdtauk]

A final round of cleaning up or adding comments to parts of the controls can be done soon, but I wanted to get the functional code in after working on it on and off outside of the repo and adding it to the repo over the past week or so

This is done now

[marcelwgn]

This method should be split into multiple smaller functions. Also, I think the comment is kind of redundant and can be left out.

[mdtauk]

I am breaking this up into smaller functions and updated comments

[0x5bfa]

I think now is good?

[marcelwgn]

Technically, this only works if number > -divider

[mdtauk]

@0x5bfa How do you suggest I change the method to ensure it works correctly?

[0x5bfa]

If you're ensuring it be positive or zero, can't it be 'result < 0 ? 0 : result'?

[0x5bfa]

What kind of modulus is this?

[marcelwgn]

I assume one of those two lines with the accompanying functions will be cleaned up?

[mdtauk]

I was testing the two easing functions, we can remove the commented out one

[mdtauk]

I will remove the comment, but keep the other easing method in case we can use it later. Unless you think we should remove the method even if it is unused in the short term?

[marcelwgn]

I think we should introduce a separate Math util file given we have multiple math "add-ons" across controls.

[mdtauk]

I will do this in a future commit. @0x5bfa If you can help me go through the various calculation methods, and separate them into their own code file, I would greatly appreciate it.