Code Quality: Improved DependencyProperty generator

[0x5bfa]

Resolved / Related Issues

The primary achievement is to reduce lines of code and verbosity when declaring DependencyProperties.

Steps used to test these changes

None

[Poker-sang]

Thanks for your help. 🤔 Since we've made it to the eve of the partial properties, maybe we can wait for C#13 to come out before making adjustments? That way we can implement it in this syntax:

[DependencyProperty(PropertyChangedCallback, etc.)]
public partial object? MyProperty { get; private set; } = new Object();

This way is much easier and more readable. And perhaps CommunityToolkit would like to implement a better version?

[Poker-sang]

@Poker-sang fyi. btw do you know how to emit ExpressionSyntax from TypedConstant that can be obtained from attribute properties list? This abb4661 does its job but looks quite bad.

If you wish to do so, then yes. You can get it through

((TypeDeclarationSyntax)generatorAttributeSyntaxContext.TargetNode).AttributeLists[0].Attributes[0].ArgumentList.Arguments[0].Expression

or

((AttributeSyntax)attributeData.ApplicationSyntaxReference).ArgumentList.Arguments[0].Expression

However the arguments of the attributes only allow constants, which I don't think is very useful, so I used string

[Poker-sang]

I think I'd like to use the latter one but there seems to be a cast error.

Oh sorry, I didn't test it. It should be .GetSyntax() or .GetSyntaxAsync():

((AttributeSyntax)attributeData.ApplicationSyntaxReference.GetSyntax()).ArgumentList.Arguments[0].Expression

[0x5bfa]

Worked thanks!!
Could you review?

[Poker-sang]

Looks good to me

[0x5bfa]

That didn't work; somehow emitted property type string like "IconType" and caused an invalid cast exception.

Reverted to your original approach, I think we can wait for .NET partial properties to achieve this as you suggested.

Again, ready.

[XTorLukas]

LGTM

[yaira2]

@0x5bfa are you ready for me to merge this?

[0x5bfa]

YES!!

[hishitetsu]

This PR disables changing the sort order by clicking on the header of the details layout.

[0x5bfa]

Fixed