Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the extract button was sometimes not displayed in the toolbar #16984

Merged

Conversation

marcofranzen99
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Set Files Dev as default application for .zip files
  2. Opened .zip file via files explorer
  3. .zip files gets opened in Files and the extract button is visible

I have also checked that the buttons are still displayed in the other cases

Files_xALYSPmgPy.mp4

@yaira2
Copy link
Member

yaira2 commented Mar 25, 2025

Can you please resolve the conflicts?

@marcofranzen99
Copy link
Contributor Author

Sometimes one of the MenuFlyoutItems is visible but disabled 🤔 I don't know why yet, will try to debug it if I have time in the next few days
image

@marcofranzen99 marcofranzen99 force-pushed the 15457_fix_extract_button branch from dc88aec to dcc7704 Compare March 29, 2025 17:34
@marcofranzen99
Copy link
Contributor Author

Sometimes one of the MenuFlyoutItems is visible but disabled 🤔 I don't know why yet, will try to debug it if I have time in the next few days

fixed

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed issue where the extract button was not displayed in the toolbar Fix: Fixed issue where the extract button was sometimes not displayed in the toolbar Mar 30, 2025
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 30, 2025
@yaira2 yaira2 merged commit b1d248c into files-community:main Mar 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When a ZIP file is opened via file association, the Extract Button is not displayed on the toolbar
2 participants