Skip to content

Feature: Added support for searching commands on the actions page #17141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 18, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Reviewed updated strings
  2. Confirmed that entering a search query filters actions in settings
  3. Confirmed that resizing the app window with the settings dialog no longer causes a crash

@yaira2 yaira2 marked this pull request as draft May 18, 2025 23:15
@yaira2
Copy link
Member Author

yaira2 commented May 18, 2025

@Lukiluc29 please let me know if there are any other strings you feel should be updated.

@yaira2 yaira2 marked this pull request as ready for review May 19, 2025 14:33
@yaira2 yaira2 changed the title Code Quality: Updated strings in the Command Palette Feature: Added support for searching commands on the actions page May 19, 2025
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 19, 2025
@yaira2 yaira2 merged commit 99e3a55 into main May 19, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/Commands branch May 19, 2025 15:32
@Lukiluc29
Copy link
Contributor

@yaira2 Can I open a PR to show you what I really think?

@yaira2
Copy link
Member Author

yaira2 commented May 19, 2025

Feel free, however, please be advised we may close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Redundant Titles and Subtitles in Command Labels Bug: Resizing the app with the settings pane open causes a crash
2 participants