Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<PackageVersion Include="System.Text.Json" Version="9.0.9" />
<PackageVersion Include="System.IO.Hashing" Version="9.0.9" />
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="9.0.9" />
<PackageVersion Include="Appium.WebDriver" Version="4.4.5" />
<PackageVersion Include="Appium.WebDriver" Version="8.0.1" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating Appium.WebDriver to 8.0.1 introduces breaking changes, causing compilation and runtime errors due to API changes.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The Appium.WebDriver dependency update to 8.0.1 introduces breaking changes. WindowsDriver is no longer generic, so WindowsDriver<WindowsElement> will cause compilation errors. Additionally, all findBy* methods (e.g., FindElementByName(), FindElementsByTagName(), FindElementByAccessibilityId()) have been removed, leading to runtime MethodNotFoundException errors or compilation failures. The pull request updates the dependency without migrating the calling code.

💡 Suggested Fix

Migrate existing code to the new Appium.WebDriver 8.0.1 API. Remove the generic type parameter from WindowsDriver. Replace findBy* methods with FindElement(AppiumBy.name()), FindElements(AppiumBy.tagName()), etc.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: Directory.Packages.props#L56

Potential issue: The `Appium.WebDriver` dependency update to 8.0.1 introduces breaking
changes. `WindowsDriver` is no longer generic, so `WindowsDriver<WindowsElement>` will
cause compilation errors. Additionally, all `findBy*` methods (e.g.,
`FindElementByName()`, `FindElementsByTagName()`, `FindElementByAccessibilityId()`) have
been removed, leading to runtime `MethodNotFoundException` errors or compilation
failures. The pull request updates the dependency without migrating the calling code.

Did we get this right? 👍 / 👎 to inform future reviews.

<PackageVersion Include="Axe.Windows" Version="2.4.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageVersion Include="MSTest.TestAdapter" Version="4.0.1" />
Expand Down
Loading