basic react UI for debugging and testing bot. Added session_id to be … #107
Conversation
…able to collect history. SalesGPT API is now created at mounting time. Changed response from api at the end of conversations to make it a list of 2 values, rather than 1 (Was throwing an error)
|
@iljamak pls accept the invite to the salesGPT org as a collaborator, otherwise the unit tests will fail as it won't load the env variables for you. Then please re-run the checks to make sure they all pass. Actually, if you can move this to be a branch in our main repo itself as a core collaborator and submit a PR from it, that'd be great, ty! The fork + PR worflow is for new/outside collaborators. |
| @@ -1,2 +0,0 @@ | |||
| OPENAI_API_KEY="xx" | |||
There was a problem hiding this comment.
@iljamak pls keep this file in - its there as a placeholder to add env vars
| allow_origins=["*"], # Allows all origins | ||
| allow_credentials=True, | ||
| allow_methods=["*"], # Allows all methods | ||
| allow_headers=["*"], # Allows all headers |
There was a problem hiding this comment.
we will want to add this to the documentation. In general, we don't want to allow all origins. Please comment on this in the README for the API and put this as a parameter on the origins + methods. This will be then used as an environmental parameter when we dockerize this.
There was a problem hiding this comment.
in other words, ALLOW_ORIGINS=["*""] etc should all be environmental variables.
| allow_credentials=True, | ||
| allow_methods=["*"], # Allows all methods | ||
| allow_headers=["*"], # Allows all headers | ||
| ) |
There was a problem hiding this comment.
please add a unit test and learn the
- Given
- When
- Then
unit test framework (work with an AI code assistant such as cursor.so on this)
| @@ -19,28 +31,34 @@ async def say_hello(): | |||
|
|
|||
|
|
|||
| class MessageList(BaseModel): | |||
There was a problem hiding this comment.
while we are add it, the run_api.py should only contain the endpoints, it's a start, we will refactor later.
But the MessageList should not be in this file.
| @@ -19,28 +31,34 @@ async def say_hello(): | |||
|
|
|||
|
|
|||
| class MessageList(BaseModel): | |||
| session_id: str | |||
| conversation_history: List[str] | |||
| human_say: str | |||
There was a problem hiding this comment.
let's change the turns to "human" and "{salesperson_name}" where the salesperson name is injected from the prompt template.
| @@ -3,11 +3,23 @@ | |||
|
|
|||
| import uvicorn | |||
| from fastapi import FastAPI | |||
There was a problem hiding this comment.
let's refactor the API a but for a "separation of concerns"
You can ask cursor to give you a better file structure.
|
|
||
| @app.post("/chat") | ||
| async def chat_with_sales_agent(req: MessageList): | ||
| sales_api = SalesGPTAPI( |
There was a problem hiding this comment.
Can we update this to use tools?
|
@iljamak closing this as migrated to the upstream repo |
…able to collect history. SalesGPT API is now created at mounting time. Changed response from api at the end of conversations to make it a list of 2 values, rather than 1 (Was throwing an error)