Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow using username as receiver #101

Merged
merged 11 commits into from
Mar 9, 2025
Merged

Conversation

Faustasm
Copy link
Contributor

@Faustasm Faustasm commented Mar 3, 2025

Allow using username as receiver.
Validation is done as per signal requirements - here
Additional validation is checking if there are no more than 9 digits and the digits are not 00 at the end of username, since signal does not allow it but does not mention it in the requirements.

Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice, I didn't realise you could use usernames as receivers.

Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy with all the changes, thanks!

@Era-Dorta Era-Dorta merged commit c86b94c into filipre:master Mar 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants