Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style on macOS #182

Closed
mantou132 opened this issue Jul 23, 2022 · 3 comments
Closed

Improve style on macOS #182

mantou132 opened this issue Jul 23, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@mantou132
Copy link

mantou132 commented Jul 23, 2022

Problem Description

Under MacOS, the title bar of the PWA does not look very beautiful

Screen Shot 2022-07-23 at 22 16 08

Proposed Solution

Imitation of chrome PWA

@mantou132 mantou132 added the enhancement New feature or request label Jul 23, 2022
@black7375
Copy link

Just Info) To write a CSS that targets a specific operating system. black7375/Firefox-UI-Fix#331 (comment)

v99 above firefox: mozilla/gecko-dev@5fed8de#diff-314c90db7a8ea5667e97a1ff5079d02192246d424244fc9dcebd568f3e1c87e7

@media (-moz-platform: linux) {
}

@media (-moz-platform: macos) {
}

@media (-moz-platform: windows) {
}

@media (-moz-platform: windows-win7) {
}

@media (-moz-platform: windows-win8) {
}

@media (-moz-platform: windows-win10) {
}

v99 below firefox:

@media (-moz-gtk-csd-available) {
  /* Linux */
}

@supports -moz-bool-pref("layout.css.osx-font-smoothing.enabled") {
  /* Mac */
}

@media (-moz-platform: windows-win7) {
}

@media (-moz-platform: windows-win8) {
}

@media (-moz-platform: windows-win10) {
}

@filips123
Copy link
Owner

Which changes exactly do you have in mind? I guess centering the title and removing that gap in the right corner? Other than that, Firefox and Chrome PWAs look pretty similar to me.

@black7375
Copy link

IMO, drag space(gap) should be located in the left corner.

@filips123 filips123 added this to the 2.0.0 milestone Jul 31, 2022
@filips123 filips123 moved this to In Progress in PWAsForFirefox Jul 31, 2022
Repository owner moved this from In Progress to Done in PWAsForFirefox Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants