Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right click menu icons and text broken (Not works -moz-os-version) #331

Closed
3 of 13 tasks
ghost opened this issue Feb 11, 2022 · 5 comments
Closed
3 of 13 tasks

right click menu icons and text broken (Not works -moz-os-version) #331

ghost opened this issue Feb 11, 2022 · 5 comments
Labels
Browser::Upstream Changes or bugs from Firefox Class::Padding Padding and margin related layout Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@ghost
Copy link

ghost commented Feb 11, 2022

Describe the bug
The logos are broken. I attempted to update with powershell before this issue, but to no fix.

Expected behavior
For the icons and text to be spaced out.

Screenshots
image

Environment:

Additional context
Firefox Nightly updated before I see this error

@ghost ghost added the Issue::Bug Something isn't working label Feb 11, 2022
@black7375 black7375 added Class::Padding Padding and margin related layout Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Browser::Upstream Changes or bugs from Firefox labels Feb 12, 2022
@black7375
Copy link
Owner

Because of this commit mozilla/gecko-dev@5fed8de

It will be changed as follows:

@media (-moz-os-version: windows-win10) {
}

to

/* v99 */
@media (-moz-platform: windows-win10) {
}

It also has a media query for Mac and Linux. mozilla/gecko-dev@5fed8de#diff-314c90db7a8ea5667e97a1ff5079d02192246d424244fc9dcebd568f3e1c87e7

@media (-moz-platform: linux), (-moz-platform: macos)  {
}

black7375 added a commit that referenced this issue Feb 12, 2022
@black7375
Copy link
Owner

I updated the code. Please do the test.

@maicol07
Copy link

@black7375 can you add that to the proton style?

@black7375
Copy link
Owner

@maicol07 yep, updated 👍

@ghost ghost changed the title right click menu icons and text broken . Apr 11, 2022
@black7375 black7375 changed the title . right click menu icons and text broken Apr 11, 2022
@black7375 black7375 mentioned this issue Apr 14, 2022
13 tasks
@Ryunam
Copy link

Ryunam commented May 29, 2022

Unfortunately I'm still experiencing this issue too on my system. Since the powershell script wasn't working, I manually updated the Leoton UI a few seconds ago by copying the relevant files in my profile directory, all in the hopes of addressing this problem.However, my icons are still overlapping with the corresponding text strings.

This is with Firefox version 100.0.2, with the "Original Lepton" style. See here for further reference:

image

image

@black7375 black7375 changed the title right click menu icons and text broken right click menu icons and text broken (Not works -moz-os-version) Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Padding Padding and margin related layout Component::Context-Menu Only for context menu Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants