Icon bar cannot be hidden

[mirenradia]

Description

Since the v2.0.x update, I can no longer hide the icon bar. I have tried in an old profile created with an older version (probably v1.4.x) and also with a new web app created in a new profile.

Steps to Reproduce

1. Create a new PWA.
2. Open it and navigate to about:config (e.g. by pressing F6).
3. Toggle firefoxpwa.enableHidingIconBar to true (it defaults to false).
4. Close and re-open PWA.
5. Attempt to hide the icon bar via one of the following methods
   a. Press Ctrl+Alt.
   b. Right click on the icon bar and uncheck 'Icon Bar'.
   c. Right click on any toolbar and go to 'Customize Toolbar'. In the bottom left, click the 'Toolbars' dropdown and uncheck 'Icon Bar'.
6. The icon bar is still visible.

Additional Information

Environment

• Operating system: Ubuntu 22.04
• System architecture: x86_64 (amd64)
• Desktop environment: KDE Plasma 5.24.4, KWin 5.24.4
• Installation method: DEB
• PWAsForFirefox extension version: 2.0.1
• PWAsForFirefox native version: 2.0.1
• Firefox version: 103.0 (PWA runtime), 103.0.1 (normal firefox)

[mirenradia]

This issue follows the discussion in #177.

[filips123]

I can reproduce it on Kubuntu, so maybe it's Linux or KDE-specific bug. Will try to check why this happens.

Edit: It also happens on Ubuntu with GNOME.

[filips123]

I quick workaround is to comment out/remove the following rules from /usr/share/firefoxpwa/userchrome/profile/chrome/pwa/content/browser.css, then enable "Always patch runtime and profile" in the extension settings (you can later disable it again) and restart your web apps:

  @media (-moz-gtk-csd-available) {
    #titlebar {
      visibility: hidden;
    }

    #titlebar > * {
      visibility: visible;
    }

    :root[tabsintitlebar][sizemode="normal"]:not([gtktiledwindow="true"]) body {
      border-top-left-radius: env(-moz-gtk-csd-titlebar-radius);
      border-top-right-radius: env(-moz-gtk-csd-titlebar-radius);
    }
  }

I will try to release a fix soon.

[mirenradia]

I quick workaround is to comment out/remove the following rules from /usr/share/firefoxpwa/userchrome/profile/chrome/pwa/content/browser.css, then enable "Always patch runtime and profile" in the extension settings (you can later disable it again) and restart your web apps:

  @media (-moz-gtk-csd-available) {
    #titlebar {
      visibility: hidden;
    }

    #titlebar > * {
      visibility: visible;
    }

    :root[tabsintitlebar][sizemode="normal"]:not([gtktiledwindow="true"]) body {
      border-top-left-radius: env(-moz-gtk-csd-titlebar-radius);
      border-top-right-radius: env(-moz-gtk-csd-titlebar-radius);
    }
  }

I will try to release a fix soon.

This worked perfectly for me. Thanks for finding it so quickly!

[yasscaleb]

this issue has shown up for me again, Arch Linux and latest KDE Plasma