Support PHP 8.0 #672
Merged
Support PHP 8.0 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
Hmm, latest PHP 7.3 seems to have a bug causing infinite recursion... https://github.com/GrahamCampbell/whoops/runs/1233865301?check_suite_focus=true. EDIT: This can be worked around by pinning the PHPUnit version. |
|
Tests passing now. Travis run: https://travis-ci.org/github/filp/whoops/builds/734453096. Actions run: https://github.com/GrahamCampbell/whoops/actions/runs/298433086. NB @filp Travis is not showing up in the status because you need to switch to travis-ci.com from .org. Github actions will only start to show up after this PR is merged. |
staabm
reviewed
Oct 10, 2020
denis-sokolov
approved these changes
Oct 17, 2020
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs HHVM and PHP 5 tests on travis. Runs PHP 7 and 8 on GitHub Actions.