Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine processor handling #32

Closed
ajafff opened this issue Jan 18, 2018 · 0 comments · Fixed by #38
Closed

refine processor handling #32

ajafff opened this issue Jan 18, 2018 · 0 comments · Fixed by #38

Comments

@ajafff
Copy link
Member

ajafff commented Jan 18, 2018

Currently processors are applied inconsistently:

  • --project
    • only applied if the file does not exists (does not allow processing files without changing the extension)
    • not applied inside node_modules (does not allow filtering / changing failures or fixes)
    • when checking for file existence it probably makes sense to only look for a processor if the file has no supported extension (filter files by extension #29)
  • without --project
    • not applied inside node_modules
    • applied if the file exists
  • processors should not modify the path at all, they should just return an additional file extension if necessary
@ajafff ajafff mentioned this issue Jan 19, 2018
Closed
ajafff added a commit that referenced this issue Jan 24, 2018
@ajafff
Refine processor handling
d7318e0 
* processors can only provide a suffix for the file name
* the name is only modified if it doesn't already have a supported extension
* files are always processed even if the name is not transformed. that allows processors to change the resulting failures.
* even files without active rules or without failures are processed
* processors also work inside node_modules now

Fixes: #32
@ajafff ajafff mentioned this issue Jan 24, 2018
Merged
3 tasks
ajafff added a commit that referenced this issue Jan 24, 2018
@ajafff
Refine processor handling
ffd9edb 
* processors can only provide a suffix for the file name
* the name is only modified if it doesn't already have a supported extension
* files are always processed even if the name is not transformed. that allows processors to change the resulting failures.
* even files without active rules or without failures are processed
* processors also work inside node_modules now

Fixes: #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Processor fimbullinter/wotan
1 participant
@ajafff