Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse ModuleResolutionCache when updating Program #608

Closed
ajafff opened this issue May 3, 2019 · 0 comments · Fixed by #609
Closed

Reuse ModuleResolutionCache when updating Program #608

ajafff opened this issue May 3, 2019 · 0 comments · Fixed by #609

Comments

@ajafff
Copy link
Member

ajafff commented May 3, 2019

Similar to microsoft/TypeScript#31100

In order to correctly implement CompilerHost.resolveModuleNames (and resolveTypeReferenceDirectives) we need to create a new instance of ProjectHost for each Program (or at least ProjectHost needs to know the CompilerOptions of the currently created/updated Program).
The cache needs to be reset if the CompilerOptions change (or for the next Program).

The linter cache #370 might benefit from this change as it needs to resolve everything as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant