Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypergrid keys not SHIFTed #770

Closed
joneit opened this issue Oct 24, 2018 · 1 comment
Closed

Hypergrid keys not SHIFTed #770

joneit opened this issue Oct 24, 2018 · 1 comment
Labels
bug

Comments

@joneit
Copy link
Contributor

joneit commented Oct 24, 2018 •
edited
Loading

When SHIFT + <some key> is pressed, the shifted version of that key is added to the keys array, but when <some key> + SHIFT is pressed, the unshifted version is added.

When SHIFT is subsequently pressed (or released), the keys array should be updated to replace the unshifted version of all keys remaining in the array with their shifted version (or vice versa).
@joneit
Copy link
Contributor Author

joneit commented Oct 25, 2018 •
edited
Loading

grid.canvas.currentKeys array is now updated whenever shift key is pressed or released.

This fix is implemented in PR #762 and will be released in version 3.1.0.

@joneit joneit closed this as completed Oct 25, 2018
joneit added a commit to joneit/core that referenced this issue Oct 25, 2018
@joneit
on keyup/down update currentKeys per SHIFT (Issue fin-hypergrid#770)
bfa3f6c
@joneit joneit mentioned this issue Oct 25, 2018
Merged
@joneit joneit added the bug label Oct 25, 2018
@joneit joneit mentioned this issue Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joneit