Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct this to make anonymous column calculator function work #784

Closed
slimtom95 opened this issue Dec 5, 2018 · 1 comment
Closed

correct this to make anonymous column calculator function work #784

slimtom95 opened this issue Dec 5, 2018 · 1 comment

Comments

@slimtom95
Copy link

There is a tiny mistake on the latest master commit caused anonymous function not work for column calculator, and here it is:

core/src/behaviors/Column.js line 393
} else if (calculator.test(REGEX_ANON_FUNC)) {
calculator is the function literal string, not an regex, this line should be
} else if (calculator.match(REGEX_ANON_FUNC)) {

Correct this and it would work fine.

@joneit
Copy link
Contributor

joneit commented Dec 5, 2018

Thanks, good catch!

I will add to the the next release, which will likely be 3.2.1 and will likely be published on the weekend.

joneit added a commit that referenced this issue May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants