-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1.6 #706
v2.1.6 #706
Conversation
…heck those instead of checkboxOnlyRowSelections; removed region selections after reindex
@Dwaynekj @dcchuck @neilslinger Will be publishing these v2 fixes as 2.1.6 at EOD today if no questions or objections. Thanks to @nmichaud for consuming/testing! J. |
@@ -721,50 +725,73 @@ var JSON = DataModel.extend('dataModels.JSON', { | |||
* @this {dataModels.JSON} | |||
* @memberOf dataModels.JSON~ | |||
*/ | |||
function getUnderlyingIndexesOfSelectedRows() { | |||
var sourceIndexes = [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a deprecation warning for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Inner" function (not exposed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, I should have expanded the view
How do we reproduce |
@Dwaynekj Umm.... just what it says: When there is only one column after one or more fixed columns. So in the demo, we already have 1 fixed column, so just reduce the the total number of columns to 2 so that there is only one column after the fixed column, and you will see the renderer start to throw errors and it hangs: grid.properties.columnIndexes = grid.properties.columnIndexes.slice(0, 2); (You cannot use |
008adee
to
b21d897
Compare
@@ -889,6 +910,10 @@ var Hypergrid = Base.extend('Hypergrid', { | |||
* Called from renderer/index.js | |||
*/ | |||
deferredBehaviorChange: function() { | |||
if (this.needsReindex) { | |||
this.behavior.reindex(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joneit Can you explain what this feature is for?
Hey @Dwaynekj |
I'm delaying 2.1.6 release for further testing. The last commit introduced a bug. I will either withdraw it or re-do it. Should be done today though..... |
2.1.6 looks good now. |
reindex
calls):restoreRowSelections
— new property (formerly controlled by thecheckboxOnlyRowSelections
property which was creating logic conflicts)restoreColumnSelections
— new property to restore column selection(s) (new feature)Behavior.prototype.getActiveColumnIndex
— a new overload accepts a column name (string) in addition to existing overloads of a data row index (number) or column (object)behavior.getColumns()
andbehavior.getActiveColumns()
arrays now also serve as column name dictionaries (point to column objects). This makesbehavior.columnEnum
(which are integers) obsolete (which will be deprecated in v3); if you need to know a column index, you can now ay for a column "per-cent" for example,grid.behavior.getColumns()['per-cent'].index
. Names with punctuation are re-added as camel case, including even legal punctuation (_
and$
); and names beginning with digit are prefixed with$
. Thus, for "per-cent" you can also saygrid.behavior.getColumns().perCent.index
.column.addProperties(newProps)
— new method doesn't clear existing props first.setState
) adjustments:behavior.clearState()
now clears columns' state as well.grid.addState(state)
andbehavior.addState(state)
— new methods that do not callclearState
before applying state.state.columnProperties
(column array) can now be an object (with indexes as keys) as well as an array, which makes for easier sparse array JSON strings. Because this object competes withstate.columns
(column collection by name), it is now always blacklisted bygrid.saveState
(so onlycolumns
is output).grid.reindex()
— Similar torepaint()
,behaviorChanged
, et al, this method can now be called repeatedly within a thread but will only ever be executed one time before the next render.undefined
with the various set property methods now deletes the property from the properties object, revealing the underlying value from the prototype.CellEvent
's row property support has been improved to be subgrid-aware. (This was an oversight.)getActiveColumnIndex(columnOrIndexOrName: (object|number|string))
— The string overload is new and accepts a column name.