Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate finagle-postgres with finagle-postgres-shapeless #103

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

leonmaia
Copy link
Collaborator

@leonmaia leonmaia commented Nov 30, 2018

Problem:
Because the projects were not aggregated we had to have separate release
processes and some logic to run both modules tests.

Solution:
Aggregate both modules.

Result:
Now we have a single process for releasing and testing both modules.

@leonmaia
Copy link
Collaborator Author

leonmaia commented Nov 30, 2018

@vkostyukov I noticed yesterday that we are missing finagle-postgres-shapeless release. We've been releasing it every time we release finagle-postgres even though there are no changes on it in the past 2 years. Which makes me think that we only do this to make its versions matching with finagle-postgres. What do you think?

cc/ @jeremyrsmith

@vkostyukov
Copy link
Collaborator

vkostyukov commented Nov 30, 2018

@leonmaia My understanding was sbt release does runs on a root project, which aggregates both, finagle-postgres and finagle-postgres-shapeless. So it should release both at the same time.

Update: Oh I see finagle-postgres-shapeles isn't aggregated into root. Maybe we should aggregate it here. This should also allow us to remove that test in Test statement at the at do the build.sbt file.

@vkostyukov
Copy link
Collaborator

Hey @leonmaia! Do you want me to give my idea a try - try to aggregate finagle-shapeless under the root project?

@leonmaia
Copy link
Collaborator Author

@vkostyukov I'll try to do this today, I'm having really busy weeks. I tried to fix when you commented but I had issues since shapeless depends on finagle-postgres, so I could not only aggregate them on the root project. But let me try this today and I'll comment here my findings/solution.

@leonmaia
Copy link
Collaborator Author

leonmaia commented Jan 8, 2019

@vkostyukov I'm with a lot of things going on and I had no time to look into this. I'll hopefully have some time next week. I'm working on sorting things out to give this project some love ❤️ .

Problem:
Because the projects were not aggregated we had to have separate release
processes and some logic to run both modules tests.

Solution:
Aggregate both modules.

Result:
Now we have a single process for releasing and testing both modules.
@leonmaia leonmaia force-pushed the postgres-shapeless-release branch from 3c3f796 to 64ac2ed Compare February 15, 2019 14:50
@leonmaia leonmaia changed the title Auto Release finagle-postgres-shapeless Aggregate finagle-postgres with finagle-postgres-shapeless Feb 18, 2019
@leonmaia
Copy link
Collaborator Author

@vkostyukov I believe these are the changes that fit what we discussed. Would you mind having a look?

@leonmaia leonmaia merged commit 25e17e6 into master Feb 18, 2019
@leonmaia leonmaia deleted the postgres-shapeless-release branch February 18, 2019 12:17
@vkostyukov
Copy link
Collaborator

Yep, this looks great! @leonmaia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants