Skip to content

Build 1.0.3 is missing typescript index.d.ts #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rosskevin opened this issue Jan 22, 2018 · 2 comments
Closed

Build 1.0.3 is missing typescript index.d.ts #7

rosskevin opened this issue Jan 22, 2018 · 2 comments

Comments

@rosskevin
Copy link
Contributor

Are you submitting a bug report or a feature request?

bug

What is the current behavior?

No ts bindings are in the build

What is the expected behavior?

source index.d.ts is built and packaged as "typings": "dist/index.d.js"

Sandbox Link

https://unpkg.com/final-form-arrays@1.0.3/dist/index.d.js
This was referenced Jan 22, 2018
Closed
Merged
@rosskevin
Copy link
Contributor Author

I'm going to go ahead and PR ts tests here as well. Working on that, will be another hour or two before I submit.

rosskevin added a commit to rosskevin/final-form-arrays that referenced this issue Jan 22, 2018
@rosskevin
fix reference to typings file final-form#7
77d51f3
@rosskevin rosskevin mentioned this issue Jan 22, 2018
Merged
@rosskevin rosskevin changed the title Build 1.0.3 is missing typescript index.d.js Build 1.0.3 is missing typescript index.d.ts Jan 22, 2018
@erikras
Copy link
Member

erikras commented Jan 22, 2018

:shipit: ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosskevin @erikras