Merge pull request #595 from willow-ahrens/wma/fix383

fixes #383
finch-tensor · Jun 12, 2024 · 7300fd9 · 7300fd9
2 parents ac76c23 + a9187b4
commit 7300fd9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/symbolic/simplify.jl b/src/symbolic/simplify.jl
@@ -100,7 +100,6 @@ function get_simplify_rules(alg, shash)
         (@rule call(ifelse, true, ~a, ~b) => a),
         (@rule call(ifelse, false, ~a, ~b) => b),
         (@rule call(ifelse, ~a, ~b, ~b) => b),
-        (@rule $(literal(-0.0)) => literal(0.0)),
         (@rule call(norm, ~x::isliteral, ~y) => if iszero(x.val) x end),
 
         (@rule block(~a1..., sieve(~c, ~b1), sieve(~c, ~b2), ~a2...) =>

diff --git a/test/test_interface.jl b/test/test_interface.jl
@@ -4,6 +4,15 @@ using Finch: AsArray
 
     @info "Testing Finch Interface"
 
+    #https://github.com/willow-ahrens/Finch.jl/issues/383
+    let
+        A = [0.0 0.0 4.4; 1.1 0.0 0.0; 2.2 0.0 5.5; 3.3 0.0 0.0]
+        A_fbr = Tensor(Dense(Dense(Element(0.0))), A)
+
+        -A # works
+        -A_fbr # used to fail
+    end
+
     @testset "permutedims" begin
         let
             io = IOBuffer()