This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Don't #[allow(type_alias_bounds)]. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubnt-intrepid
approved these changes
Sep 18, 2018
|
Thanks for submit the PR. The CI result will be temporarily broken, but I'll fix it after approve this patch. |
ubnt-intrepid
added a commit
that referenced
this pull request
Sep 18, 2018
Note: In Rust2018, the bounds in type alias will be treated as an error and some `#[allow(type_alias_bounds)]` was removed in #314.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#54090 will fix false positives (maybe relevant?) and make it an error in the upcoming Rust 2018 edition, which means that if you want to migrate to Rust 2018, it shouldn't be ignored.
See also rust-lang/rust#49441 (comment) for the decision and some background.