Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ant task silently ignores empty excludeFilter #83

Merged
merged 1 commit into from
Sep 23, 2016
Merged

ant task silently ignores empty excludeFilter #83

merged 1 commit into from
Sep 23, 2016

Conversation

Crydust
Copy link

@Crydust Crydust commented Feb 5, 2016

Logging a warning will prevent confusion.

Also see question on StackOverflow:
FindBugs Exclude filter with Ant
http://stackoverflow.com/questions/24275252/findbugs-exclude-filter-with-ant/35222903

Logging a warning will prevent confusion.

Also see question on StackOverflow:
FindBugs Exclude filter with Ant
http://stackoverflow.com/questions/24275252/findbugs-exclude-filter-with-ant/35222903
@Crydust
Copy link
Author

Crydust commented Apr 9, 2016

We make it explicit in the warning whether the file is empty or doesn't exist.

I'd like to point out that file.length() == 0 doesn't imply file.exists().
The documentation for the file.length method is here:
https://docs.oracle.com/javase/8/docs/api/java/io/File.html#length--

@Crydust
Copy link
Author

Crydust commented Sep 22, 2016

Is there anything wrong with this pull request? I'd be happy to make changes if requested.

@iloveeclipse iloveeclipse merged commit b10d87c into findbugsproject:master Sep 23, 2016
@iloveeclipse
Copy link
Member

Thanks. Ping help sometimes :-)

sebasjm pushed a commit to sebasjm/findbugs that referenced this pull request Mar 11, 2018
ant task silently ignores empty excludeFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants