Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer phpunit versions and update docblocks #118

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Allow newer phpunit versions and update docblocks #118

merged 4 commits into from
Feb 24, 2020

Conversation

mmachatschek
Copy link
Contributor

Purpose

  • Allow newer PHPUnit versions.
  • Use <Object>[] syntax in docblock.

Open Questions and Pre-Merge TODOs

  • composer lint and composer fix was executed.
  • Tests were written and pass with 100% coverage.

@mmachatschek mmachatschek requested a review from howard February 22, 2020 22:55
@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #118 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             develop   #118   +/-   ##
========================================
  Coverage        100%   100%           
  Complexity       269    269           
========================================
  Files             49     49           
  Lines            701    700    -1     
========================================
- Hits             701    700    -1
Impacted Files Coverage Δ Complexity Δ
src/FINDOLOGIC/Export/Exporter.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/FINDOLOGIC/Export/XML/Page.php 100% <ø> (ø) 9 <0> (ø) ⬇️
src/FINDOLOGIC/Export/XML/XMLItem.php 100% <ø> (ø) 26 <0> (ø) ⬇️
...rt/Exceptions/EmptyElementsNotAllowedException.php 100% <100%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f6bf3...85c089d. Read the comment docs.

@howard howard merged commit 63c89d0 into findologic:develop Feb 24, 2020
@mmachatschek mmachatschek deleted the minor_code_changes branch March 8, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants