Merged
Conversation
added 2 commits
January 23, 2018 14:18
Change the implementation so the client needs to be initialized only once and can be reused to make requests concurrently. For that purpose, the V4 signature logic (ahem blindly copy/pasted from AWS code) don’t use instance variables to store the date when the client was initialized. Instead, the date is taken when a request is issued. Also slightly refactored the code to follow some Java best practices. Most of them were suggested by an IDE though.
rborer
force-pushed
the
use-date-of-request
branch
from
fd66473 to
23b8781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the implementation so the client needs to be initialized only once and can be reused to make requests concurrently.
For that purpose, the V4 signature logic (ahem blindly copy/pasted from AWS code) don’t use instance variables to store the date when the client was initialized. Instead, the date is taken when a request is issued.
Also slightly refactored the code to follow some Java best practices. Most of them were suggested by an IDE though.