Replace RefreshControl with native #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyMomot
requested review from
a team,
bstien and
osanoj
and removed request for
a team
I would say to remove it if we will not use it, might be good to keep it until you replaced all usages in all repos though - unless you already have? |
osanoj
approved these changes
Jun 14, 2024
osanoj
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Going away from FINN's style of RefreshConrol and UIActivityIndicatorView
JIRA
What?
Replace custom RefreshConrol with native
Instead of replacing all entities of LoadingIndicatorView for ios-app and SDKs I'm just making from it an extension of UIActivityIndicatorView in this PR
Version Change
Minor
UI Changes